test: add coverage for vulnerability severity scores

Signed-off-by: Keshav Priyadarshi <git@keshav.space>

Author: keshav-space

vulnerabilities/tests/test_data/postgresql/parse-advisory-postgresql-expected.json

@@ -63,9 +63,7 @@
           {
             "system": "cvssv3",
             "value": "6.7",
-            "scoring_elements": [
-              "AV:L/AC:H/PR:L/UI:R/S:U/C:H/I:H/A:H"
-            ]
+            "scoring_elements": "CVSS:3.0/AV:L/AC:H/PR:L/UI:R/S:U/C:H/I:H/A:H"
           }
         ]
       },
@@ -144,9 +142,7 @@
           {
             "system": "cvssv3",
             "value": "3.1",
-            "scoring_elements": [
-              "AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:L/A:N"
-            ]
+            "scoring_elements": "CVSS:3.0/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:L/A:N"
           }
         ]
       },

vulnerabilities/tests/test_importer.py

@@ -13,6 +13,7 @@
 from vulnerabilities.importer import PackageCommitPatchData
 from vulnerabilities.importer import PatchData
 from vulnerabilities.importer import ReferenceV2
+from vulnerabilities.importer import VulnerabilitySeverity
 from vulnerabilities.pipes.advisory import classify_patch_source
 
 
@@ -201,3 +202,26 @@ def test_classify_patch_source_integration(url, commit_hash, patch_text, results
             assert actual_data_obj.reference_id == expected_data_obj.reference_id
             assert actual_data_obj.reference_type == expected_data_obj.reference_type
             assert actual_data_obj.url == expected_data_obj.url
+
+
+def test_vulnerability_severity_cvss_validation():
+    severity = VulnerabilitySeverity.from_dict(
+        {
+            "system": "cvssv3",
+            "value": "7.5",
+            "scoring_elements": "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N",
+        }
+    )
+
+    assert severity.scoring_elements == "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N"
+
+
+def test_vulnerability_severity_cvss_validation_with_invalid_value():
+    with pytest.raises(ValueError):
+        VulnerabilitySeverity.from_dict(
+            {
+                "system": "cvssv3",
+                "value": "7.5",
+                "scoring_elements": "CVSS:3.0/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:N/A:N",
+            }
+        )

vulnerabilities/tests/test_utils.py

@@ -186,15 +186,15 @@ def setUp(self):
                 VulnerabilitySeverity.from_dict(
                     {
                         "system": "cvssv4",
-                        "value": "7.5",
-                        "scoring_elements": "AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
+                        "value": "7.6",
+                        "scoring_elements": "CVSS:4.0/AV:A/AC:H/AT:P/PR:N/UI:N/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N/MPR:N",
                     }
                 ),
                 VulnerabilitySeverity.from_dict(
                     {
                         "system": "cvssv3",
-                        "value": "6.5",
-                        "scoring_elements": "AV:N/AC:L/PR:L/UI:N/S:U/C:H/I:H/A:H",
+                        "value": "7.5",
+                        "scoring_elements": "CVSS:3.0/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:N/A:N",
                     }
                 ),
             ],
@@ -250,7 +250,7 @@ def setUp(self):
 
     def test_compute_content_id_v2(self):
         result = utils.compute_content_id_v2(self.advisory1)
-        self.assertEqual(result, "5211f1e6c3d935759fb288d79a865eeacc06e3e0e352ab7f5b4cb0e76a43a955")
+        self.assertEqual(result, "c302966268cd63444978df6a131f8d4f9e15544cdb18799dc844fb7b94089f02")
 
     def test_content_id_from_adv_data_and_adv_model_are_same(self):
         id_from_data = utils.compute_content_id_v2(self.advisory1)