From 5ce580885ce57727d3da3aecf95586ce02991130 Mon Sep 17 00:00:00 2001 From: turegjorup Date: Thu, 9 Jul 2026 10:56:07 +0200 Subject: [PATCH 1/2] ci: fix api-spec no-change detection for oasdiff v0.1.x MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The changelog step's "spec changed?" guard grepped for the literal "no changes", but oasdiff v0.1.x emits "No changelog changes" when the spec is unchanged — the substring never matched, so has_changes was always true and a "⚠️ non-breaking changes" comment posted (body: "No changelog changes") even for PRs that don't touch the spec (e.g. the Elasticsearch bump #60). Match both wordings with a regex so the no-change path is taken and the sticky comment resolves to ✅. --- .github/workflows/api-spec.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/api-spec.yml b/.github/workflows/api-spec.yml index ba00c4a..7dd51eb 100644 --- a/.github/workflows/api-spec.yml +++ b/.github/workflows/api-spec.yml @@ -163,7 +163,9 @@ jobs: - name: Determine whether the spec changed id: changes run: | - if [ -s changelog.md ] && ! grep -qi 'no changes' changelog.md; then + # oasdiff writes "No changelog changes" (v0.1.x) / "No changes" (older) + # when the spec is unchanged; treat either as no change. + if [ -s changelog.md ] && ! grep -qiE 'no (changelog )?changes' changelog.md; then echo "has_changes=true" >> "$GITHUB_OUTPUT" else echo "has_changes=false" >> "$GITHUB_OUTPUT" From 4e3dcfc8e26ba3401e8344247c125fb738190453 Mon Sep 17 00:00:00 2001 From: turegjorup Date: Thu, 9 Jul 2026 10:56:37 +0200 Subject: [PATCH 2/2] docs: add CHANGELOG entry for api-spec no-change detection fix --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index e7869f9..f63ea1c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,8 @@ See [keep a changelog] for information about writing changes to this log. ## [Unreleased] +- [PR-61](https://github.com/itk-dev/event-database-api/pull/61) + Fix the API-spec workflow's no-change detection for oasdiff v0.1.x ("No changelog changes" wording) - [PR-60](https://github.com/itk-dev/event-database-api/pull/60) Upgrade Elasticsearch to 8.19.18 (dev image) and the `elasticsearch/elasticsearch` client constraint to `^8.19` - [PR-59](https://github.com/itk-dev/event-database-api/pull/59)