[ImgBot] Optimize images#6
Closed
imgbot[bot] wants to merge 1 commit into
Closed
Conversation
*Total -- 707.46kb -> 618.46kb (12.58%) /frontend/public/placeholder.jpg -- 1.04kb -> 0.47kb (54.61%) /frontend/public/apple-icon.png -- 2.56kb -> 1.29kb (49.73%) /docs/dashboard.png -- 118.21kb -> 100.21kb (15.22%) /frontend/public/icon.svg -- 1.27kb -> 1.11kb (12.65%) /chrome/extension-src/store-assets/screenshot-1280x800.png -- 564.86kb -> 496.85kb (12.04%) /frontend/public/icon-dark-32x32.png -- 0.57kb -> 0.54kb (6.15%) /chrome/extension-src/icons/icon-128.png -- 14.97kb -> 14.06kb (6.1%) /frontend/public/icon-light-32x32.png -- 0.55kb -> 0.54kb (2.47%) /chrome/extension-src/icons/icon-48.png -- 3.41kb -> 3.39kb (0.49%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2233admin
added a commit
that referenced
this pull request
Jul 8, 2026
New backend/browser_act/ package (distinct from backend/cli.py and backend/browser_act_packs/). Wraps the external `browser-act` binary: version(), get_skills(), and a session(name, env) async context manager yielding navigate/wait/eval/state/click/input. Subprocess safety mirrors channels/cli_channel.py: create_subprocess_exec + wait_for(timeout) + TimeoutError -> kill()+wait() (no orphan). Binary via BROWSER_ACT_BIN env (mirrors OPENCLI_BIN); browser_act_timeout added to Settings. All argv-only (decision #6): never shell, user values always single argv elements; BrowserActError text excludes env secrets. session __aexit__ is a documented no-op (browser lifecycle is PR-C, decision xjh1994#10). 19 tests incl. shell-injection safety (asserts create_subprocess_shell never called, dangerous strings stay one verbatim argv element) + secret-not-leaked. 1448 -> 1467 passed, zero regression.
2233admin
added a commit
that referenced
this pull request
Jul 8, 2026
…PR-C) New channel_type "browser_act" (registered). Generic interpreter of a pack's channel.manifest.json (no per-pack code): resolves the pack via PackCatalog, replays manifest.steps against a browser-act session (PR-B), and for each eval_script step runs the pack's scripts/*.py to emit JS then evals it in the browser and JSON-parses the DOM result. - backend/browser_act/scripts.py: run_pack_script() — the second subprocess hop, create_subprocess_exec(sys.executable, ...) argv-only (decision #6), timeout+kill, ScriptError. - backend/channels/browser_act_channel.py: collect/validate_config/health_check. Login/anti-bot detection (decision #4): a script's {error:true,message} matching an auth keyword -> error_type="needs_human", stops, never retries or bypasses. Pagination interprets url_page + "result_count<N" stop_when, else falls back to max_pages(5) + empty-page stop (limitations documented). Bad-manifest KeyError/JSON/schema errors return a ChannelResult, never crash. Env secrets never enter error text or metadata. Registering the channel legitimately expands list_channel_types(), so the workflow-capabilities exact-set test gains "browser_act" (+1 line). 17 tests (happy/needs_human/generic-error/validate/health/registry/ secret-not-leaked/script-hop injection-safety/template-mismatch). 1467 -> 1484 passed, zero regression (full suite verified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 13% 🎉
Details
📝 docs |
repo | 🙋🏾 issues | 🏪 marketplace
~Imgbot - Part of Optimole family