Skip to content

Update: replace removed Thread.stop() with stream-close cancellation#3851

Merged
georgweiss merged 2 commits into
ControlSystemStudio:masterfrom
gian21391:update-replace-thread-stop
Jul 9, 2026
Merged

Update: replace removed Thread.stop() with stream-close cancellation#3851
georgweiss merged 2 commits into
ControlSystemStudio:masterfrom
gian21391:update-replace-thread-stop

Conversation

@gian21391

Copy link
Copy Markdown

Download cancellation in Update relied on Thread.stop(), which is removed in
recent JDKs and already throws UnsupportedOperationException at runtime on the
JDK 21 target, so cancelling was a silent no-op. The download watcher now closes
the source stream on cancel to abort the in-progress Files.copy. This is a step
towards improving support for JDK 26, where the old code no longer compiles.

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented
    • The documentation is up to date
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@sonarqubecloud

Copy link
Copy Markdown

@georgweiss

Copy link
Copy Markdown
Collaborator

@kasemir, any reason to not merge?

@kasemir

kasemir commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

No, go ahead

@georgweiss georgweiss merged commit f1ccbd4 into ControlSystemStudio:master Jul 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants