Switch to TreeTableView in save&restore#3872
Open
georgweiss wants to merge 4 commits into
Open
Conversation
|
jacomago
reviewed
Jul 8, 2026
| import java.util.ResourceBundle; | ||
| import java.util.ServiceLoader; | ||
| import java.util.Stack; | ||
| import java.util.*; |
Contributor
There was a problem hiding this comment.
Do we normally do * imports?
Collaborator
Author
There was a problem hiding this comment.
No, will update.
| <?import javafx.scene.text.Font?> | ||
|
|
||
| <BorderPane xmlns="http://javafx.com/javafx/17.0.12" xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController"> | ||
| <BorderPane xmlns="http://javafx.com/javafx/26" xmlns:fx="http://javafx.com/fxml/1" fx:controller="org.phoebus.applications.saveandrestore.ui.SaveAndRestoreController"> |
Contributor
There was a problem hiding this comment.
javafx version is still 21 in pom.xml?
Collaborator
Author
There was a problem hiding this comment.
Fixed in another commit.
| import java.io.FileReader; | ||
| import java.io.FileWriter; | ||
|
|
||
| public class FixElasticImport { |
Contributor
There was a problem hiding this comment.
Better to remove in this commit with a rebase rather than pollute the git history.
Collaborator
Author
There was a problem hiding this comment.
Fair enough. Will do next time.
Contributor
There was a problem hiding this comment.
So the readback column is gone?
Collaborator
Author
There was a problem hiding this comment.
There is no read-back column in the TreeTableView of objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon user request: improve metadata visibility on objects in the hierarchy view by moving from tooltip to content rendered in TreeCell. Decided though that a TreeTableView is a better match for showing more data, in particular as user may hide unwanted columns.
This change also offers the possibility to sort on date or user name.
Testing:
Documentation: