move infinite sky's actual work code to Maps#5822
Merged
Merged
Conversation
the infinite sky plugin will still handle the "automatic" extension, but the code to actually extend the map block columns moves to the Maps module this is due to a request from a modder to be able to extend map block columns from scripts without having to rely on a plugin API call
ctrlaltmilk
reviewed
Jul 8, 2026
ctrlaltmilk
left a comment
ctrlaltmilk
left a comment
There was a problem hiding this comment.
Review mentioned on Discord, mostly minor questions
should be slightly more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the infinite sky plugin will still handle the "automatic" extension, but the code to actually extend the map block columns moves to the Maps module
this is due to a request from a modder to be able to extend map block columns from scripts without having to rely on a plugin API call