[8.0] test: Python 3.14 and matplotlib 3.11 compatibility in test suite#8702
Open
chrisburr wants to merge 4 commits into
Open
[8.0] test: Python 3.14 and matplotlib 3.11 compatibility in test suite#8702chrisburr wants to merge 4 commits into
chrisburr wants to merge 4 commits into
Conversation
exec/eval-based imports break on Python 3.13+ (PEP 667) with a NameError.
A plot is accepted when it matches any of several reference images, so a matplotlib upgrade that changes the rendering only needs an extra reference image (<stem>.<tag>.png) rather than replacing the existing one.
Rendered with the matplotlib shipped in DIRACOS for Python 3.14, so the plot comparison tests pass on both the previous and the new matplotlib.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8695 to
rel-v8r0.Summary
importlib.import_module/getattrinstead ofexec/eval. Theexec/evalform raisesNameErroron Python 3.13+ (PEP 667); rel-v8r0 still used it, so this fix is only needed here.assertDictContainsSubset(removed in Python 3.12) withassertLessEqual(subset.items(), full.items()).referenceImages/compareToReferences).