Remove redundant null checks in rxjava2 instrumentation (current Context is never null)#11875
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 7ec48b4 | Docs | Datadog PR Page | Give us feedback! |
PerfectSlayer
left a comment
There was a problem hiding this comment.
Looking good. Thanks for the follow up changes
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
fcbb916 to
0f72563
Compare
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
291064f to
89f8653
Compare
0f72563 to
1f238e0
Compare
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
…ext is never null)
1f238e0 to
7ec48b4
Compare
amarziali
left a comment
There was a problem hiding this comment.
thanks. there are probably others to clean up elsewhere
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Motivation
Simpler code, avoids unnecessarily storing root context - now matches the rxjava 3 instrumentation.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue/merge. You can also:/merge --commit-message "..."/merge -c/merge -f --reason "reason"; please use this judiciously, as some checks do not run at the PR-level (note: the PR still needs to be mergeable, this will only skip the pre-merge build)Jira ticket: [PROJ-IDENT]