fix(mcp): return semantic-only graph results as primary#938
Open
SyntaxSawdust wants to merge 1 commit into
Open
fix(mcp): return semantic-only graph results as primary#938SyntaxSawdust wants to merge 1 commit into
SyntaxSawdust wants to merge 1 commit into
Conversation
Signed-off-by: Dustin Persek <dustin.persek@protonmail.com>
Owner
|
Thanks for the semantic_query fix for #915. Triage: high-priority query correctness bug. Review should verify semantic-only calls put vector-ranked hits in the primary results array, combined structural+semantic behavior stays compatible, and total/has_more report the semantic candidate set rather than the broad structural fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #915.
search_graphnow returns vector-ranked semantic hits in the primaryresultsarray for semantic-onlysemantic_querycalls, instead of returning broad structural results that can make vector-less nodes appear to win the ranking.Combined structural + semantic calls still expose
semantic_results, and non-arraysemantic_queryvalues still return the existing validation error. The vector search path now also reports a full semantic candidate count sototalandhas_morestay meaningful withlimit/offsetpagination.Local full-suite caveat:
make -f Makefile.cbm testis not green in this environment, but the failing graph-contract/probe slice reproduces on a cleanupstream/mainworktree, so it is not introduced by this patch. Focused MCP proof andlint-ciare green.Checklist
git commit -s) — required, CI rejectsunsigned commits (DCO, see CONTRIBUTING.md)
make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)