Skip to content

Fixes for tests#62

Merged
MJGaughran merged 13 commits into
mainfrom
fixes-for-tests
Jul 9, 2026
Merged

Fixes for tests#62
MJGaughran merged 13 commits into
mainfrom
fixes-for-tests

Conversation

@MJGaughran

Copy link
Copy Markdown
Contributor

These are the code changes that were made for the improved suite of tests. This includes:

  • Removal of dead code (aiming for high coverage)
  • Renaming confusing variables
  • Use of consistent error handling
  • Fixing a couple bugs

Each type of fix is covered by a separate commit.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.54545% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (61d4864) to head (6740295).

Files with missing lines Patch % Lines
src/deploy_tools/snapshot.py 41.17% 10 Missing ⚠️
src/deploy_tools/compare.py 0.00% 9 Missing ⚠️
src/deploy_tools/models/save_and_load.py 66.66% 2 Missing ⚠️
src/deploy_tools/sync.py 88.88% 2 Missing ⚠️
src/deploy_tools/deploy.py 66.66% 1 Missing ⚠️
src/deploy_tools/validate.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   83.59%   82.53%   -1.07%     
==========================================
  Files          27       27              
  Lines         957      979      +22     
==========================================
+ Hits          800      808       +8     
- Misses        157      171      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptsOSL ptsOSL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MJGaughran MJGaughran merged commit 5c86a9c into main Jul 9, 2026
9 of 11 checks passed
@MJGaughran MJGaughran deleted the fixes-for-tests branch July 9, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants