Use cryptography's non-deprecated CFB location when available#1034
Open
okke-formsma wants to merge 1 commit into
Open
Use cryptography's non-deprecated CFB location when available#1034okke-formsma wants to merge 1 commit into
okke-formsma wants to merge 1 commit into
Conversation
CFB moved from cryptography.hazmat.primitives.ciphers.modes to cryptography.hazmat.decrepit.ciphers.modes in cryptography 47, which is also exactly when the old location started emitting CryptographyDeprecationWarning on attribute access. Prefer the new location when it exists, falling back to the old one on cryptography < 47 where decrepit does not exist yet. This removes the warning both at import time and when AESCipher is actually used with cfb mode, for every supported cryptography version. Fixes IdentityPython#1033
okke-formsma
force-pushed
the
fix/lazy-aescipher-postfix-mode
branch
from
8b98fe3 to
5b8dd74
Compare
okke-formsma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1033.
CFB moved from cryptography.hazmat.primitives.ciphers.modes to cryptography.hazmat.decrepit.ciphers.modes in cryptography 47, which is also exactly when the old location started emitting CryptographyDeprecationWarning on attribute access.
This prefers the new location when it exists, falling back to the old one on cryptography < 47 where decrepit does not exist yet. That removes the warning both at import time and when AESCipher is actually used with cfb mode, for every supported cryptography version.
All 7 existing tests in test_92_aes.py pass unchanged, tested against cryptography 43.0.3 and 49.0.0.