Add dpctl dtype objects#2335
Draft
ndgrigorian wants to merge 2 commits into
Draft
Conversation
dpctl dtype objects and DpctlScalar allow support for new or exotic kernel arguments, including sycl::half and complex numbers per SYCL, only permit native endianness
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2335/index.html |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes the addition of
_dtypes.py, which implements dtype-related classes for dpctl, as well as a broadening of the permitted inputs as dpctl kernel argumentsPreviously, complex scalars and float16 could not be passed to kernels, as ctypes lacks either of these constructs. Additionally, the kernel submission functions required ctypes arguments, rather than generic Python scalars or even NumPy scalars.
This PR proposes the addition of a
DpctlScalarbase class which defines scalars (using NumPy) anddpctl.dtype, which carries dtype metadata, as well as the expansion of permitted kernel arguments to include NumPy scalars and Python scalars