Resolve conda-build’s dependency analysis warnings#2772
Open
antonwolfy wants to merge 8 commits into
Open
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2772/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_30 ran successfully. |
Collaborator
|
coverage: 78.109% (-0.002%) from 78.111% — resolve-conda-build-warnings into master |
antonwolfy
force-pushed
the
resolve-conda-build-warnings
branch
from
9df6735 to
9e44657
Compare
…rning is false-positive
antonwolfy
force-pushed
the
resolve-conda-build-warnings
branch
from
9e44657 to
c1a8aab
Compare
NumPy and Python enter `run` via auto-injected run_exports (numpy is in host via build-system.requires; python is the interpreter). dpnp uses them only through C headers and the stable NumPy C-API at build time, so those ABI pins scan as unused "overdepends". The real runtime deps stay as the explicit numpy/python lines under requirements/run.
The libDPCTLSyclInterface.so is dynamically linked but resolved at runtime via
a relative RPATH into the dpctl package's directory, so conda-build's
overlinking scan cannot attribute it to a package. dpctl is guaranteed to
be installed by the explicit pin_compatible('dpctl', ...) run dependency.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conda-build's post-build dependency analysis was emitting a number of warnings on every package build (both Linux and Windows). This PR resolves them — partly by adding genuinely-missing run dependencies, and partly by silencing the
false positives that come from conda-build's static scan being unable to see header-only usage and runtime (RPATH /
add_dll_directory) library resolution.No runtime behavior changes; this is a conda recipe / CI hygiene change.