Align dpnp.tensor.expand_dims with Python array API 2025.12#2988
Merged
antonwolfy merged 8 commits intoJul 8, 2026
Conversation
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
coverage: 78.11%. remained the same — align-tensor.expand_dims-with-array-api-2025.12 into master |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_28 ran successfully. |
ndgrigorian
approved these changes
Jul 7, 2026
github-actions Bot
added a commit
that referenced
this pull request
Jul 8, 2026
This PR aligns `dpnp.tensor.expand_dims` with the Python array API specification (revision 2025.12), which defines the signature as `expand_dims(x, /, axis)` — `axis` is a **required** positional-or-keyword argument with no default. Previously the tensor-level function used `expand_dims(X, /, *, axis=0)` (`axis` keyword-only with a default of `0`), which did not match the standard. The public `dpnp.expand_dims` wrapper is also made positional-only for its array argument (`(a, /, axis)`), consistent with sibling array-API functions in the same module (`squeeze`, `reshape`, `broadcast_to`, `stack`). The function body was already multi-axis capable; this change updates the signature and documentation to match, and closes gaps in test coverage. edda84d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns
dpnp.tensor.expand_dimswith the Python array API specification (revision 2025.12), which defines the signature asexpand_dims(x, /, axis)—axisis a required positional-or-keyword argument with no default.Previously the tensor-level function used
expand_dims(X, /, *, axis=0)(axiskeyword-only with a default of0), which did not match the standard.The public
dpnp.expand_dimswrapper is also made positional-only for its array argument ((a, /, axis)), consistent with sibling array-API functions in the same module (squeeze,reshape,broadcast_to,stack).The function body was already multi-axis capable; this change updates the signature and documentation to match, and closes gaps in test coverage.