Adding Leetcode and /eightball responses#487
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthrough
ChangesBot Message Constants Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/tk/src/consts/index.ts`:
- Around line 19-23: The LeetCode reminder is still using a separate
DAILY_MESSAGES list instead of the shared constants, so the new strings in the
shared export are never picked up. Update the LeetCode cron logic in leetcode.ts
to import and use the shared daily-message export from consts/index.ts, and
remove the duplicate DAILY_MESSAGES definition so there is a single source of
truth.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: efb1a21b-782b-4920-b378-3de2e1152f32
📒 Files selected for processing (1)
apps/tk/src/consts/index.ts
| "Lock in!", | ||
| "Time to use 101% of your brain power! 🧠", | ||
| "Time to beat 100% submissions with your algorithms!", | ||
| "1337 1337 1337...", | ||
| "Rise up, coding people!" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== apps/tk/src/consts/index.ts ==\n'
wc -l apps/tk/src/consts/index.ts
sed -n '1,240p' apps/tk/src/consts/index.ts
printf '\n== apps/cron/src/crons/leetcode.ts ==\n'
wc -l apps/cron/src/crons/leetcode.ts
sed -n '1,240p' apps/cron/src/crons/leetcode.ts
printf '\n== Search DAILY_MESSAGES / EIGHTBALL_RESPONSES usage ==\n'
rg -n "DAILY_MESSAGES|EIGHTBALL_RESPONSES" apps -g '!**/node_modules/**'Repository: KnightHacks/forge
Length of output: 11275
Use the shared daily-message list
apps/cron/src/crons/leetcode.ts still has its own DAILY_MESSAGES, so these new strings in apps/tk/src/consts/index.ts never reach the LeetCode reminder. Move the cron to the shared export (or remove the duplicate) so there’s one source of truth.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/tk/src/consts/index.ts` around lines 19 - 23, The LeetCode reminder is
still using a separate DAILY_MESSAGES list instead of the shared constants, so
the new strings in the shared export are never picked up. Update the LeetCode
cron logic in leetcode.ts to import and use the shared daily-message export from
consts/index.ts, and remove the duplicate DAILY_MESSAGES definition so there is
a single source of truth.
Why
Adding new prompts to TK's daily Leetcode reminders and /eightball responses.
What
Added new prompts inside the 2 arrays
DAILY_MESSAGES(5 new prompts) andEIGHTBALL_RESPONSES(11 new responses) offorge/apps/tk/src/consts/index.ts.Test Plan
Since the prompts of daily Leetcode reminders and /eightball responses are randomized (and I failed to set up the appropriate environment to start TK on my end), I want to have the bot tested in the Knight Hacks Discord server.
Checklist
Summary by CodeRabbit