Skip to content

feat(tui): add config key support to provider create/update forms#2224

Open
letv1nnn wants to merge 5 commits into
NVIDIA:mainfrom
letv1nnn:tui-provider-config-keys-creation
Open

feat(tui): add config key support to provider create/update forms#2224
letv1nnn wants to merge 5 commits into
NVIDIA:mainfrom
letv1nnn:tui-provider-config-keys-creation

Conversation

@letv1nnn

Copy link
Copy Markdown

Summary

Add config key (config map) support to the TUI's Create Provider and Update Provider forms.

Previously, both forms only handled credentials and hardcoded config: HashMap::default(), making it impossible to set provider config keys like ANTHROPIC_BASE_URL or OPENAI_BASE_URL via openshell term. The CLI's --config KEY=VALUE flag worked correctly, only the TUI surface was affected.

Related Issue

#1798

Changes

  • Create Provider form: Added config key/value input section with Tab-based navigation between key and
    value fields, auto-commit on Tab, and Ctrl+D to delete entries
  • Update Provider form: Added config key/value editing with existing config hydrated from the provider
    on form open, preserving config that the user doesn't modify
  • Spawn functions: spawn_create_provider and spawn_update_provider now plumb the form's config map
    into the gRPC request instead of sending empty maps

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Screenshots

You can run cargo run -p openshell-cli -- term to try it out yourself.

Provider Details now lists config keys:

image

Updating Provider Details

image image

letv1nnn added 5 commits July 8, 2026 12:13
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
Signed-off-by: Artem Lytvyn <alytvyn@redhat.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 11, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@letv1nnn

Copy link
Copy Markdown
Author

I have read the DCO document and I hereby sign the DCO.

@letv1nnn

Copy link
Copy Markdown
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant