ABF Fix v1 date parsing#1870
Open
h-mayorquin wants to merge 1 commit into
Open
Conversation
zm711
reviewed
Jul 7, 2026
| ss = int(ss) | ||
| header["rec_datetime"] = datetime.datetime(YY, MM, DD, hh, mm, ss, ms) | ||
| try: | ||
| header["rec_datetime"] = datetime.datetime(YY, MM, DD, hh, mm, ss, ms) |
Contributor
There was a problem hiding this comment.
I'm wondering if we could check for the two bad values instead of try-except which can mask errors. What if there is another error mode that we miss because of this try-except that we would catch if we explicitly check for 0 or 0xFFFF... before attempting the date time.datetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that we were hard-coding this.