Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7807 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17219 17234 +15
=======================================
+ Hits 17050 17065 +15
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit f5ba166 Download link for the artifact containing the test results: ↓ atime-results.zip
|
joshhwuu
reviewed
Jul 6, 2026
| ansvals = chmatch(ansvars, names_x) | ||
| } | ||
| # if (!length(ansvars)) Leave ansvars empty. Important for test 607. | ||
| if (".SD" %chin% av && any(all.names(jsub) %chin% c("<-", "="))) { |
Member
There was a problem hiding this comment.
curious: will we ever have a situation where we could have a DT nested within the expression? would the top level DT warn or the nested?
jangorecki
reviewed
Jul 7, 2026
| test(2377.91, truelength(dt$a), 0L) | ||
| test(2377.92, {setallocrow(dt); truelength(dt$a)}, 3L) | ||
|
|
||
| # 7431 warn when .SD is returned after local assignment to .SD columns |
Member
There was a problem hiding this comment.
I would keep # and issue number together, as this is how we always search for comments related to an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7431
this pr updates :