Skip to content

Light Calorimetry (Production)#911

Open
lynnt20 wants to merge 102 commits into
production/sbnd-gen2from
feature/lynnt_lightcalorimetry
Open

Light Calorimetry (Production)#911
lynnt20 wants to merge 102 commits into
production/sbnd-gen2from
feature/lynnt_lightcalorimetry

Conversation

@lynnt20

@lynnt20 lynnt20 commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Identical to #878.

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links

Accompanying PRs: SBNSoftware/sbnanaobj#189, SBNSoftware/sbncode#639, SBNSoftware/sbnobj#171. References updated to reflect the PRs to gen2.

aliciavr and others added 19 commits October 9, 2025 04:05
@aliciavr
Setup to start extended fragments feature
151b2c9
@aliciavr
Shift timing function
1e492fd
@aliciavr
Waveforms decoding function
3f93ceb
@aliciavr
Add dump waveforms function
b416a56
@aliciavr
Combine waveforms and correctly differentiates nominal from extended
0d9f644
@aliciavr
Combine all extended fragments succesfully
c1a42c0
@aliciavr
Add new comments for code documenting. New variable for debugging the…
e165606 
… extended fragments combination
@aliciavr
Update SBN Document for reference
60036c5
@aliciavr
Add version number and update number of debug waveforms to 0
2f7ff45
@aliciavr
First version of timing check implemented (some extended fragments do…
15f34cd 
… not fulfill the requirements
@aliciavr
Add jittering debug option and combine fragments option
3f44697
@aliciavr
Update combination condition with timing features integrating the exp…
43f7614 
…ected jittering of the extended fragments.
@aliciavr
Add warning for some unexpected types of fragments and fix fragments …
177f2b4 
…indexing. Improve jittering application.
@lgarren
remove or disable files which reference LegacyLArG4
9b056c4
@lgarren
remove or disable files which reference LegacyLArG4
9297360
@lgarren
remove or disable files which reference LegacyLArG4
a531049
@aliciavr
Restore the shower merging algorithm in another place to avoid incons…
cc0cd3a 
…istent state of PFParticles (-1 track scores).
@AndyChappell
Add fcl and pandora xml to support cluster validation metrics in ci s…
888ecbb 
…ystem
@AndyChappell
Add synchronisation comment to Pandora Master xml
bcb99ee
@nathanielerowe nathanielerowe self-requested a review February 13, 2026 17:07
@nathanielerowe

nathanielerowe commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_14_02_03 LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02 SBNSoftware/sbndaq-artdaq-core@v1_10_06 SBNSoftware/sbn*@SBN_SUITE_v10_14_02_03

@FNALbuild

FNALbuild commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild

FNALbuild commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild

FNALbuild commented Feb 17, 2026

Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

nathanielerowe and others added 19 commits March 13, 2026 12:55
@nathanielerowe
Merge branch 'develop' into feature/lg_geant4_11
18f9f5b
@nathanielerowe
Merge pull request #903 from lgarren/feature/lg_geant4_11
8cb3f91 
build with geant4 v4_11_2_p02
@nathanielerowe
Merge branch 'develop' into feature/hlay_crt_blobs
8d5b79e
@nathanielerowe
Merge pull request #916 from SBNSoftware/feature/hlay_crt_blobs
f23c4b0 
CRT Blobs
@nathanielerowe
Merge branch 'develop' into feature/hlay_crt_saturation
5ae81e8
@nathanielerowe
Merge pull request #917 from SBNSoftware/feature/hlay_crt_saturation
8f5dd42 
CRT Saturation
@nathanielerowe
Merge branch 'develop' into ci_memory_updates
38d8ed4
@nathanielerowe
Merge pull request #921 from SBNSoftware/ci_memory_updates
130c116 
Updating Memory and CPU Usage Error Bounds for CI Tests
@nathanielerowe
Update sbncode version to v10_20_03
a1cccf8
@nathanielerowe
Merge branch 'develop' into feature/hlay_crt_channel_map_evds
30b75c8
@nathanielerowe
Merge branch 'develop' into feature/hlay_crt_ana
c06fc26
@nathanielerowe
Merge pull request #920 from SBNSoftware/feature/hlay_crt_ana
43e7807 
CRT Analysis Tools
@nathanielerowe
Merge branch 'develop' into feature/hlay_crt_channel_map_evds
1b8c860
@nathanielerowe
Merge pull request #918 from SBNSoftware/feature/hlay_crt_channel_map…
4f6b3ea 
…_evds

CRT Channel Mapping Event Displays
@nathanielerowe
Merge branch 'develop' into feature/chappell_ci_pandora_clstr
782ea81
@nathanielerowe
Merge pull request #909 from SBNSoftware/feature/chappell_ci_pandora_…
04e41a8 
…clstr

Pandora CI cluster metrics
@nathanielerowe
Update versioning
62fc4d5
@nathanielerowe
Merge branch 'release/v10_20_03'
41d1365
@nathanielerowe
Merge tag 'v10_20_03' into develop
9f1fff2 
Version v10_20_03
This was referenced Mar 31, 2026
Merged
Merged
Merged
@hgreenlee hgreenlee requested a review from linyan-w July 7, 2026 17:36
linyan-w
linyan-w approved these changes Jul 7, 2026
View reviewed changes

@linyan-w linyan-w left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I thought we merged light calorimetry but apparently not yet...! As long as this is identical to the dev version it's good with me.

@linyan-w linyan-w moved this to Reviewer Approved in SBND 2025 Gen2 Production Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linyan-w linyan-w linyan-w approved these changes
@nathanielerowe nathanielerowe nathanielerowe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

SBND 2025 Gen2 Production
Status: Reviewer Approved

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@lynnt20 @nathanielerowe @FNALbuild @linyan-w @aliciavr @lgarren @AndyChappell @henrylay97