Avoid materializing entire time vector from zarr for time_to_sample_index#4620
Open
grahamfindlay wants to merge 1 commit into
Open
Avoid materializing entire time vector from zarr for time_to_sample_index#4620grahamfindlay wants to merge 1 commit into
grahamfindlay wants to merge 1 commit into
Conversation
…ndex `np.searchsorted` is fine for mem-maps, but for out-of-core arrays (zarr) it reads the whole time vector (even if a `zarr.Array`) into memory. Bisecting instead reads O(log N) elements, which saves an order of magnitude of RAM for long recordings. """
grahamfindlay
added a commit
to grahamfindlay/spikeinterface
that referenced
this pull request
Jun 16, 2026
Member
|
Stumbled upon the same issue yesterday!! Elegant solution :) |
alejoe91
added
core
Contributor
Author
|
@alejoe91 Pretty sure this is hitting #4601 too. Both safe to merge. I can work on a PR to fix the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.searchsortedis fine for mem-maps, but for out-of-core arrays (zarr) it reads the whole time vector (even if azarr.Array) into memory. Bisecting instead reads O(log N) elements, which saves an order of magnitude of RAM for long recordings.