Add SortingAnalyzer.split() function for aggregated analyzers#4660
Open
alejoe91 wants to merge 5 commits into
Open
Add SortingAnalyzer.split() function for aggregated analyzers#4660alejoe91 wants to merge 5 commits into
SortingAnalyzer.split() function for aggregated analyzers#4660alejoe91 wants to merge 5 commits into
Conversation
alejoe91
added
core
alejoe91
commented
Jul 8, 2026
chrishalcrow
reviewed
Jul 8, 2026
| and "aggregation_key" in self.get_recording_property_keys() | ||
| ) | ||
|
|
||
| def split_aggregated(self): |
Member
There was a problem hiding this comment.
I'm not a huge fan of this name. split_by_aggregation_key?
Member
Author
There was a problem hiding this comment.
Mmmm....aggregation key is our internal naming so I don't think it's very informative to the user
chrishalcrow
approved these changes
Jul 8, 2026
chrishalcrow
left a comment
chrishalcrow
left a comment
Member
There was a problem hiding this comment.
Approve, modulo the name.
Very neat PR!
chrishalcrow
reviewed
Jul 9, 2026
chrishalcrow
reviewed
Jul 9, 2026
Co-authored-by: Chris Halcrow <57948917+chrishalcrow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns a dictionary with sliced analyzers in units/channels and a helper
is_aggregatedfunction