Add interpolation_kwargs to interpolate_templates#4665
Open
chrishalcrow wants to merge 2 commits into
Open
Conversation
chrishalcrow
added
generators
zm711
reviewed
Jul 8, 2026
| if interpolation_method == "thin_plate": | ||
|
|
||
| tps_interpolator = RBFInterpolator(source_locations, template, kernel="thin_plate_spline", neighbors=12) | ||
| if "neighbors" not in interpolation_kwargs: |
Member
There was a problem hiding this comment.
I'm a little wary of this. Why should we add in neighbors? If someone has poorly formed interpolation_kwargs shouldn't we let the function fail so the person can adjust themselves?
Member
Author
There was a problem hiding this comment.
It will run and give nonsense results for any probes with more than, say, 32 channels.
I don't think this is much different than setting default kwargs in other methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the user to pass interpolate_templates to interpolate_templates.