Remove submitty_count from csci1200#41
Conversation
There was a problem hiding this comment.
I had a fair amount of trouble with the setup for reviewing this PR. Eventually I got to this point, where I uploaded a configuration using submitty_count_ts and got this as the autograding result:
In the docker container, I am able to run the submitty_count_ts commands afaik.
Here is what my config that I uploaded looks like:
Edit, I just realized I forgot to put the -l after submitty_count_ts. I will test again shortly
roye2
left a comment
There was a problem hiding this comment.
After correcting my setup, I was able to verify that a) submitty_count no longer works on this docker image and b) submitty_count_ts does work and autograding works as normal. Approving.
bmcutler
left a comment
There was a problem hiding this comment.
let's call this tag summer26
What is the current behavior?
Fixes Submitty Issue#11784 - This one of the companion PRs to Submitty PR#12609.
What is the new behavior?
submitty_count is longer installed in preparation for deprecation.
Other information?
This is a breaking change. Any autograding that uses the old submitty_count instead of submitty_count_ts will no longer work.
dagemcn/dockerimages:csci1200-testadding it through docker UI)submitty_countwithwhere
IMAGE_NAMEis the name of the image, for example,dagemcn/dockerimages:csci1200-testif you reused mine.3. Create a gradeable using submitty_count, (Tutorial examples 04, 06, and 07 all utilize submitty_count)
4. Test that submitty_count will not work in the config and that submitty_count_ts successfully runs
5. Also test that regular autograding works successfully on the image
Attached is a zip of a sample solution and gradeable config with both submitty_count and submitty_count_ts commands present for testing.
example.zip