-
Notifications
You must be signed in to change notification settings - Fork 6
[Refactor:Developer] Replace submitty_count #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dagemcn
wants to merge
6
commits into
main
Choose a base branch
from
remove_submitty_count
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−23
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66969d1
removed submitty_count, need to fix loop depth
dagemcn 0f29a7a
07 should always return full credit now
dagemcn f4742bd
commected out entire testcase
dagemcn 7f7fce0
removed comments
dagemcn a73abd6
reverted changes made during testing
dagemcn 6e1067b
fixed broken configs
dagemcn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dagemcn marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am concerned that anything testing this gradeable will be expecting autograding results. But, it does look like the cypress spec 'verify_tutorial_courses' only checks if you can submit, so it should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,32 @@ | ||
| // FIXME: In the process of deprecating submitty_count and replacing it with submitty_count_ts, the loop depth functionality | ||
| // was lost. This example should either be updated or removed. | ||
| { | ||
| "testcases" : [ | ||
| { | ||
| "title" : "Python - Determine Loop Depth", | ||
| ] | ||
| // { | ||
| // "title" : "Python - Determine Loop Depth", | ||
|
|
||
| // Here, an instructor-provided static analysis script is used, rather | ||
| // than one of the provided scripts like count_token and count_function. | ||
| // This works in much the same way as those scripts. | ||
| "command" : [ "submitty_count -l python depth loop *.py" ], | ||
| "points" : 10, | ||
| "validation" : [ | ||
| { | ||
| "method" : "intComparison", | ||
| "actual_file" : "STDOUT.txt", | ||
| "description" : "Loop Depth", | ||
| // "command" : [ "submitty_count -l python depth loop *.py" ], | ||
| // "" | ||
| // "command" : [ "submitty_count_ts -l python call print *.py" ], | ||
| // "points" : 10, | ||
| // "validation" : [ | ||
| // { | ||
| // "method" : "intComparison", | ||
| // "actual_file" : "STDOUT.txt", | ||
| // "description" : "Loop Depth", | ||
|
|
||
| "comparison" : "le", | ||
| "term" : 3, | ||
| // "comparison" : "ge", | ||
| // "term" : 3 , | ||
|
|
||
| "failure_message" : "Must have less than four nested loops", | ||
| "show_message" : "always", | ||
| "show_actual" : "always" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| // // "failure_message" : "Must have less than four nested loops", | ||
| // // "show_message" : "always", | ||
| // "show_actual" : "always" | ||
| // } | ||
| // ] | ||
| // } | ||
| // ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.