Fix generated client mixed request bodies#26
Merged
Volv-G merged 1 commit intoJul 10, 2026
Conversation
Assisted-By: devx/ab04ee6e-8d31-4580-9a88-93ad2a8b42e8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bodyescape hatch for generated methods with request bodies, then merge it with named simple fields.tangle-clito0.1.2andtangle-apito0.1.1.Root cause
The generator only emitted named parameters for simple request-body fields and suppressed the generic
bodyparameter whenever any simple body field existed. For mixed request bodies, complex/object fields were silently dropped. This affected required fields such aspipeline_task_specon the pipeline-schedule endpoints androot_folderon component-library create/update.Fix
Generated client methods now mirror the CLI transport semantics:
bodyis available for every request-body operation.bodyas the base payload.Verification
uv run pytest tests/test_codegen.py -q→ 29 passeduv run pytest tests/test_packaging.py tests/test_codegen.py -q→ 39 passeduv run pytest -q→ 626 passed, 4 warnings/tmp/oasis_openapi.jsonand smoke-checkedschedules_post_pipelines/schedules_patch_pipelines; both can carrypipeline_task_specviabody, while named scalar fields override duplicate body keys.Follow-up
The downstream discovery-side update is intentionally separate: bump the submodule, rerun
generate-tangle-api.sh, and delete the manualclient.pywrappers.