test(deps): assert tensorflow stays unpinned across profiles#55
Open
ff225 wants to merge 1 commit into
Open
Conversation
The previous test required platform-split, version-capped tensorflow pins (>=2.16,<2.17 on Intel macOS, >=2.17,<3 elsewhere), but pyproject declares tensorflow unpinned so profiles aren't tied to a release. Reconcile the test with that intent: each runtime profile must have exactly one tensorflow requirement with no version specifier and no platform marker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconcile
tests/unit/test_dependency_profiles.pywith the actual dependency design.The test
test_tensorflow_uses_platform_specific_supported_versionsasserted platform-split, version-cappedtensorflowpins (>=2.16,<2.17on Intel macOS,>=2.17,<3elsewhere). Butpyproject.tomldeclarestensorflowunpinned in every runtime profile so the project isn't tied to a specific release — the assertions had drifted from reality and the test failed withStopIteration.Change
Replaced it with
test_tensorflow_is_declared_unpinned_in_every_profile, which asserts each runtime profile (server,client-static,client-laptop,client-raspberry-pi) has exactly onetensorflowrequirement with no version specifier and no platform marker (still guarding against a straytensorflow-macos).No production code or
pyproject.tomlchanges — keepingtensorflowversion-agnostic is intentional.Test
Full fast suite: 176 passed, 1 skipped.