[GTK][WPE] Add webkit_feature_list_find() to the API#1699
Open
pgorszkowski-igalia wants to merge 1 commit into
Open
[GTK][WPE] Add webkit_feature_list_find() to the API#1699pgorszkowski-igalia wants to merge 1 commit into
pgorszkowski-igalia wants to merge 1 commit into
Conversation
https://bugs.webkit.org/show_bug.cgi?id=307069 Reviewed by Michael Catanzaro and Patrick Griffis. Add a convenience function to find a WebKitFeature from a given WebKitFeatureList. This will avoid code repetition in different projects. * Source/WebKit/UIProcess/API/glib/WebKitFeature.cpp: (webkit_feature_list_find): * Source/WebKit/UIProcess/API/glib/WebKitFeature.h.in: * Tools/MiniBrowser/gtk/main.c: (parseFeaturesOptionCallback): (findFeature): Deleted. Replaced with webkit_feature_list_find(). * Tools/MiniBrowser/wpe/main.cpp: (activate): (findFeature): Deleted. Replaced with webkit_feature_list_find(). * Tools/TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: (testWebKitFeatures): Add a few test cases for the new function. Canonical link: https://commits.webkit.org/307348@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.webkit.org/show_bug.cgi?id=307069
Reviewed by Michael Catanzaro and Patrick Griffis.
Add a convenience function to find a WebKitFeature from a given WebKitFeatureList. This will avoid code repetition in different projects.
(findFeature): Deleted. Replaced with webkit_feature_list_find().
(findFeature): Deleted. Replaced with webkit_feature_list_find().
Canonical link: https://commits.webkit.org/307348@main
85fd7ef