fix!: TaskState.UNRECOGNIZED is called TASK_STATE_UNSPECIFIED in spec#974
fix!: TaskState.UNRECOGNIZED is called TASK_STATE_UNSPECIFIED in spec#974kabir wants to merge 3 commits into
Conversation
…ED in spec BREAKING CHANGE: This is an actual bug in our implementation so it was seen as suitable for a micro release. Users compiling against UNRECOGNIZED will need to replace this with TASK_STATE_UNSPECIFIED.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request renames the UNRECOGNIZED enum constant to TASK_STATE_UNSPECIFIED in TaskState and updates its usages across various mappers and managers. The review feedback highlights an incorrect mapping in TaskStateMapper.toProto where TASK_STATE_UNSPECIFIED is mapped to the synthetic protobuf value UNRECOGNIZED instead of TASK_STATE_UNSPECIFIED. Additionally, the feedback requests updating outdated Javadoc references to UNRECOGNIZED in both TaskState and TaskStateMapper_v0_3.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request renames the UNRECOGNIZED task state to TASK_STATE_UNSPECIFIED across the SDK client, mappers, and specification to align with the standard naming convention. The review feedback suggests updating outdated Javadoc comments in TaskState.java and TaskStateMapper.java to ensure consistency with the new enum constant names and actual implementation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request replaces the UNRECOGNIZED task state enum value with TASK_STATE_UNSPECIFIED across several modules, including client task management, gRPC mappers, and compatibility mappers. This change ensures consistent naming conventions for unspecified or unknown task states. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
wushunhao
left a comment
wushunhao
left a comment
There was a problem hiding this comment.
It looks good, but I found another inconsistency.
According to 4.1.3. TaskState, TASK_STATE_UNSPECIFIED is not described as a terminal state.
But I guess it also makes sense to terminate the task when it's in this state. What do you think?
|
@wushunhao I'll try to make it non-terminal and see what happens on CI |
2 participants
BREAKING CHANGE: This is an actual bug in our implementation so it was seen as suitable for a micro release. Users compiling against UNRECOGNIZED will need to replace this with TASK_STATE_UNSPECIFIED.
Fixes #958 🦕