Fix: c_parser ignored scopes with nameless inline struct#17
Merged
Conversation
The `parse_type` would continue looking for tokens even when the c_type
ended with a `{`. This would mean that the following resulted in an
exception:
```
__struct__ = """
struct {
int i;
} s;
"""
```
`parse_type` now ignores any following tokens if `c_type` ends with an
`{` - meaning the tokens afterwards are not element of the current type
scope.
Signed-off-by: Sophie Tyalie <dev@flowerpot.me>
Owner
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
parse_typefunction would continue looking for tokens to complete its type even when the last token was a{and a new scope was created. This would mean that the following resulted in an exception as the read c_type wasstruct { intinstead of simplystruct {This merge fixes that issue by ignoring all following tokens in
parse_typeif the last one opened a new scope.Signed-off-by: Sophie Tyalie dev@flowerpot.me