fix(provider): extract OpenAI-shaped error messages#36411
Open
AayushMainali-Github wants to merge 1 commit into
Open
fix(provider): extract OpenAI-shaped error messages#36411AayushMainali-Github wants to merge 1 commit into
AayushMainali-Github wants to merge 1 commit into
Conversation
OpenAI-compatible bodies put the text under error.message, but parsing grabbed the error object first and dropped the real message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36410
Type of change
What does this PR do?
Provider error parsing used
body.message || body.error || body.error?.message. For OpenAI-shaped bodies,body.erroris an object, so the realerror.messagewas skipped and users got a generic status line or raw JSON.Extraction now prefers string
message/error/error.messagefields. Added unit tests for the OpenAI object shape and stringerror.How did you verify your code works?
Ran
bun test test/provider/error.test.tsinpackages/opencode.Checklist