Fix Ubuntu/Debian package installation#13207
Draft
vishesh92 wants to merge 2 commits into
Draft
Conversation
Member
Author
|
@blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Debian/Ubuntu cloudstack-common post-install script to use Python 3 byte-compilation tooling during package installation, aiming to resolve install-time failures related to Python compilation steps.
Changes:
- Replace
pycompileinvocations withpy3compileindebian/cloudstack-common.postinst. - Keep post-install Python module copying and explicit
python3 -m py_compile/compileallsteps intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13207 +/- ##
============================================
- Coverage 18.09% 18.09% -0.01%
- Complexity 16732 16733 +1
============================================
Files 6037 6037
Lines 542780 542811 +31
Branches 66464 66471 +7
============================================
+ Hits 98233 98235 +2
- Misses 433499 433529 +30
+ Partials 11048 11047 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17954 |
Member
|
@blueorangutan test debian12 kvm-debian12 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16140) |
boring-cyborg
Bot
added
component:networking
component:storage
component:XenServer
Python
Member
Author
|
@blueorangutan package |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 11 comments.
Comments suppressed due to low confidence (1)
scripts/storage/secondary/cloud-install-sys-tmplt.py:176
file(...)is not defined in Python 3, so these calls will raiseNameErrorat runtime. Replace withopen(..., 'wb')(and consider using context managers) for decompression output andtemplate.propertieswrites.
def uncompressFile(self, fileName):
print('Uncompressing the file %s... which could take a long time, please wait' % self.systemvmtemplatepath)
if self.fileextension == 'gz':
compressedFile = gzip.GzipFile(self.systemvmtemplatepath, 'rb')
decompressedData = compressedFile.read()
compressedFile.close()
decompressedFile = file(fileName, 'wb')
decompressedFile.write(decompressedData)
decompressedFile.close()
Comment on lines
+28
to
31
| if which py3compile >/dev/null 2>&1; then | ||
| py3compile -p cloudstack-common /usr/share/cloudstack-common | ||
| fi | ||
|
|
| if self.args.templatesuffix: | ||
| self.templatesuffix = self.args.templatesuffix | ||
| print 'Password for DB: %s'%self.databaseuserpassword | ||
| print('Password for DB: %s'%self.databaseuserpassword) |
Comment on lines
110
to
127
| def runCmd(self, cmds): | ||
| process = subprocess.Popen(' '.join(cmds), shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) | ||
| stdout, stderr = process.communicate() | ||
| print(stdout) | ||
| if process.returncode != 0: | ||
| raise Exception(stderr) | ||
| return stdout | ||
|
|
||
| def runMysql(self, query): | ||
| try: | ||
| print 'Running Query: %s' % query | ||
| print('Running Query: %s' % query) | ||
| mysqlCmds = ['mysql', '--user=%s'%self.databaseusername, '--host=%s'%self.databasehostname, '--password=%s'%self.databaseuserpassword, '--skip-column-names', '-U', 'cloud', '-e "%s"'%query] | ||
| templateId = self.runCmd(mysqlCmds) | ||
| print 'TemplateId is : %s' % templateId | ||
| except Exception, e: | ||
| print('TemplateId is : %s' % templateId) | ||
| except Exception as e: | ||
| err = '''Encountering an error when executing mysql script\n%s''' % str(e) | ||
| self.errorAndExit(err) | ||
| return templateId |
Comment on lines
119
to
+123
| try: | ||
| print 'Running Query: %s' % query | ||
| print('Running Query: %s' % query) | ||
| mysqlCmds = ['mysql', '--user=%s'%self.databaseusername, '--host=%s'%self.databasehostname, '--password=%s'%self.databaseuserpassword, '--skip-column-names', '-U', 'cloud', '-e "%s"'%query] | ||
| templateId = self.runCmd(mysqlCmds) | ||
| print 'TemplateId is : %s' % templateId | ||
| except Exception, e: | ||
| print('TemplateId is : %s' % templateId) |
| modfile = "%s/%s.py" % (modpath, cs.getName().lower()) | ||
| me = os.path.abspath(__file__) | ||
| if os.path.isfile(modfile): | ||
| if hashlib.md5(open(me).read()).hexdigest() != hashlib.md5(open(modfile).read()).hexdigest(): |
| sys.exit(2) | ||
| params = {} | ||
| pos = 0; | ||
| for i in range(len(paramList) / 2): |
Comment on lines
594
to
595
| if val in ["10", "100", "1000"]: | ||
| settings += ['duplex', 'val'] |
| network_conf.close() | ||
| except Exception, e: | ||
| except Exception as e: | ||
| raise Error("failed to determine network backend:" + e) |
| if len(sys.argv) < 4: | ||
| print "Usage: prepare_kickstart_kerneal_initrd.py path_to_kernel path_to_initrd path_kernel_initrd_copy_to" | ||
| sys.exit(1) | ||
| print("Usage: prepare_kickstart_kerneal_initrd.py path_to_kernel path_to_initrd path_kernel_initrd_copy_to") |
| if __name__ == "__main__": | ||
| if len(sys.argv) < 12: | ||
| print "Usage: prepare_tftp_bootfile.py tftp_dir mac cifs_server share directory image_to_restor cifs_username cifs_password ip netmask gateway" | ||
| print("Usage: prepare_tftp_bootfile.py tftp_dir mac cifs_server share directory image_to_restor cifs_username cifs_password ip netmask gateway") |
weizhouapache
approved these changes
May 22, 2026
| if len(sys.argv) < 4: | ||
| print "Usage: prepare_kickstart_kerneal_initrd.py path_to_kernel path_to_initrd path_kernel_initrd_copy_to" | ||
| sys.exit(1) | ||
| print("Usage: prepare_kickstart_kerneal_initrd.py path_to_kernel path_to_initrd path_kernel_initrd_copy_to") |
| if __name__ == "__main__": | ||
| if len(sys.argv) < 12: | ||
| print "Usage: prepare_tftp_bootfile.py tftp_dir mac cifs_server share directory image_to_restor cifs_username cifs_password ip netmask gateway" | ||
| print("Usage: prepare_tftp_bootfile.py tftp_dir mac cifs_server share directory image_to_restor cifs_username cifs_password ip netmask gateway") |
Contributor
|
Dear @vishesh92, just for clarification. The title says Ubuntu and the description says Debian. Which ones is this fix for? Or is it for the Debian-based, that includes Ubuntu? |
Member
Author
The packages are same for both Ubuntu and Debian. |
vishesh92
changed the title
Member
|
@vishesh92 |
Member
Author
I couldn't confirm if some of the scripts works as expected before and after changes. Should we rely on just BO for this? @blueorangutan package |
|
@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18424 |
Member
|
@blueorangutan test debian12 kvm-debian12 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests |
Member
|
@vishesh92 |
|
[SF] Trillian test result (tid-16454)
|
Member
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18486 |
Member
|
@blueorangutan test ubuntu24 xcpng82 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + xcpng82) has been kicked to run smoke tests |
|
[SF] Trillian Build Failed (tid-16499) |
|
[SF] Trillian Build Failed (tid-16503) |
Member
|
@blueorangutan test ubuntu24 xenserver-84 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + xenserver-84) has been kicked to run smoke tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes package installation errors on Ubuntu and debian
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?