-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add SECURITY.md #3643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emkornfield
wants to merge
2
commits into
apache:master
Choose a base branch
from
emkornfield:security.md
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−0
Open
Add SECURITY.md #3643
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| <!-- | ||
| ~ Licensed to the Apache Software Foundation (ASF) under one | ||
| ~ or more contributor license agreements. See the NOTICE file | ||
| ~ distributed with this work for additional information | ||
| ~ regarding copyright ownership. The ASF licenses this file | ||
| ~ to you under the Apache License, Version 2.0 (the | ||
| ~ "License"); you may not use this file except in compliance | ||
| ~ with the License. You may obtain a copy of the License at | ||
| ~ | ||
| ~ http://www.apache.org/licenses/LICENSE-2.0 | ||
| ~ | ||
| ~ Unless required by applicable law or agreed to in writing, | ||
| ~ software distributed under the License is distributed on an | ||
| ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| ~ KIND, either express or implied. See the License for the | ||
| ~ specific language governing permissions and limitations | ||
| ~ under the License. | ||
| --> | ||
|
|
||
| # Security | ||
|
|
||
| ## Reporting a Vulnerability | ||
|
|
||
| Please report suspected vulnerabilities privately to the Parquet Project Management | ||
| Committee at private@parquet.apache.org. Do **not** file a public GitHub issue or pull | ||
| request for a suspected vulnerability, as that would disclose it before a fix is available. | ||
|
|
||
| When reporting, please include as much of the following as you can: | ||
| * a description of the vulnerability and its potential impact; | ||
| * the affected version(s) or commit; | ||
| * steps to reproduce, and a proof of concept if available. | ||
|
|
||
| You should receive an acknowledgement from the security team. Please follow the Apache | ||
| Software Foundation's vulnerability handling process, described at | ||
| https://www.apache.org/security/, and do not publicly disclose the issue until it has been | ||
| resolved and an advisory has been published. | ||
|
|
||
| ## Threat model | ||
|
|
||
| General assumptions about the usage of the Parquet library: | ||
|
|
||
| * Read configuration (e.g. Hadoop configuration) is controlled by applications. If an application allows untrusted parties to set the read configuration arbitrarily, that is a security risk independent of whether a Parquet file is involved. | ||
| * Parquet files (their data and metadata) may originate from untrusted sources. The library parses them on a best-effort basis, but a maliciously crafted file can still cause excessive resource consumption (e.g. large memory allocations or decompression bombs). Applications reading untrusted files are responsible for imposing appropriate resource limits (memory, time, input size) around the library. Where appropriate, improvements to resource management in the library are welcome. | ||
|
|
||
| ### Class loading | ||
|
|
||
| Several modules (e.g. parquet-avro, parquet-protobuf, parquet-thrift, etc.) provide functionality to translate Parquet data into Java objects. In the general case, this requires loading classes named in metadata stored in the Parquet files. | ||
|
|
||
| As a consequence: | ||
| * When using these translation layers it is the user's responsibility to make sure their classpath is secure and does not contain any classes that when loaded might cause an adverse issue for their system. | ||
| * If class loading driven by file contents is problematic, end users should use APIs to directly read the data from Parquet instead of relying on translation. | ||
| * Arbitrary class loading by itself is not considered a security issue by the library. A security issue must demonstrate further ability to execute | ||
| arbitrary methods on the instantiated object. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The security contact should start with
security@. There are two kinds of PMCs at the ASF:security@apache.org, in which case we apply a "false positive filter" to avoid forwarding spam.security@apache.org, and we only forward reports that are VALID according to the project's threat model, or that reveal a gap in it.If you'd like your own list, you can request a project-specific security mailing list. Either way, I'd prefer
private@parquet.apache.orgnot be used as the security contact.