GH-3652: Use assertThat checks in parquet-format-structures/parquet-encoding/parquet-thrift tests#3650
Open
nastra wants to merge 1 commit into
Open
GH-3652: Use assertThat checks in parquet-format-structures/parquet-encoding/parquet-thrift tests#3650nastra wants to merge 1 commit into
nastra wants to merge 1 commit into
Conversation
nastra
commented
Jul 8, 2026
| job.setOutputFormatClass(NullOutputFormat.class); | ||
| } | ||
|
|
||
| protected void assertEqualsExcepted(List<StructWithUnionV2> expected, List<Object> found) throws Exception { |
Contributor
Author
There was a problem hiding this comment.
this wasn't used anymore
nastra
force-pushed
the
assertj-parquet-multiple
branch
from
d65e6ab to
46ed57e
Compare
…quet-encoding/parquet-thrift tests
nastra
force-pushed
the
assertj-parquet-multiple
branch
from
46ed57e to
e62afcd
Compare
nastra
commented
Jul 9, 2026
| "base_info.nested.field", | ||
| "a.b.c.prexpost", | ||
| "a.b.c.prezapost"); | ||
| assertThat(filter.keep("home.phone_number")).isTrue(); |
Contributor
Author
There was a problem hiding this comment.
this way it's easier to spot which of the pattern is the cause if the test ever fails
Contributor
Author
nastra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Switching assertions from JUnit4-style Assert to AssertJ makes code easier to read and debug when tests fail.
What changes are included in this PR?
This updates parquet-format-structures / parquet-encoding / parquet-thrift tests to use AssertJ checks, which provide more fluent assertions and more detailed information when assertions fails on CI.
The changes in this PR were done with the help of Claude but I manually reviewed every single LOC
Are these changes tested?
yes, existing tests
Are there any user-facing changes?
no