PHOENIX-7955 CREATE TABLE IF NOT EXISTS should not mutate existing HBase table properties#2569
Draft
PDavid wants to merge 2 commits into
Draft
Conversation
…ase table properties Problem: When CREATE TABLE IF NOT EXISTS was executed against an already-existing table, Phoenix would overwrite the HBase-level table and column family properties (e.g. REGION_REPLICATION, VERSIONS, TTL) with the values from the new DDL statement. This is unexpected - IF NOT EXISTS should be a no-op if the table already exists. Fix: In ConnectionQueryServicesImpl changed ensureTableCreated call for TABLE types - passes modifyExistingMetaData = false when the table type is TABLE, so existing properties are not overwritten. Testing: Added new test in CreateTableIT which reproduces the problem and verifies the fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
PDavid
force-pushed
the
PHOENIX-7955-create-existing-table-hbase-properties
branch
from
da941d5 to
2419cbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Problem
When CREATE TABLE IF NOT EXISTS was executed against an already-existing table, Phoenix would overwrite the HBase-level table and column family properties (e.g. REGION_REPLICATION, VERSIONS, TTL) with the values from the new DDL statement. This is unexpected - IF NOT EXISTS should be a no-op if the table already exists.
(Please see the ticket about reproduction steps.)
Fix
TODO
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new test in CreateTableIT which reproduces the problem and verifies the fix.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.6 noreply@anthropic.com