refactor: remove browserPoolOptions from BrowserCrawler#3785
Open
yuvrajsingh2428 wants to merge 2 commits into
Open
refactor: remove browserPoolOptions from BrowserCrawler#3785yuvrajsingh2428 wants to merge 2 commits into
yuvrajsingh2428 wants to merge 2 commits into
Conversation
yuvrajsingh2428
changed the title
B4nan
added
the
t-tooling
barjin
reviewed
Jul 1, 2026
barjin
left a comment
barjin
left a comment
Member
There was a problem hiding this comment.
Thank you @yuvrajsingh2428 for drafting this PR.
I believe the original request feature has design flaws. Let us discuss this before proceeding with work on this PR.
Cheers!
Author
|
@janbuchar @barjin Just following up on the discussion above. I'm happy to either adapt this PR to a revised approach or close it if the consensus is to keep supporting both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserPoolOptionsfromBrowserCrawlerbrowserPoolwhen custom browser pool configuration is neededPlaywrightCrawler,PuppeteerCrawler, andStagehandCrawlerto create a defaultBrowserPoolwhen one is not providedbrowserPoolCloses #3728