Skip to content

fix: correct branch in thirdweb template links (main -> master)#1698

Open
haileymarshall wants to merge 1 commit into
base:masterfrom
haileymarshall:fix/thirdweb-demos-branch-link
Open

fix: correct branch in thirdweb template links (main -> master)#1698
haileymarshall wants to merge 1 commit into
base:masterfrom
haileymarshall:fix/thirdweb-demos-branch-link

Conversation

@haileymarshall

Copy link
Copy Markdown

What changed? Why?

The Thirdweb integration guide links to the base-account-thirdweb-template in the base/demos repo using a /tree/main/ URL, but that repo's default branch is master, so both links 404:

  • https://github.com/base/demos/tree/main/base-account/base-account-thirdweb-template404
  • https://github.com/base/demos/tree/master/base-account/base-account-thirdweb-template200

This updates both occurrences in docs/base-account/framework-integrations/thirdweb.mdx (the inline link and the GithubRepoCard) from main to master.

Notes to reviewers

  • The other 9 base/demos/tree/... links across the docs already correctly use master; these two were the only ones on main.
  • Confirmed base/demos default branch is master and the template directory exists at that path.

How has it been tested?

  • Verified the /tree/main/ URL returns 404 and the /tree/master/ URL returns 200.
  • Swept the whole docs tree for base/demos/(blob|tree|raw)/main; these two links were the only matches.

@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants