Skip to content

implement Service Route binding from v3 API. #1361#1362

Open
Lokowandtg wants to merge 2 commits into
cloudfoundry:5.x.xfrom
Lokowandtg:5.x.x
Open

implement Service Route binding from v3 API. #1361#1362
Lokowandtg wants to merge 2 commits into
cloudfoundry:5.x.xfrom
Lokowandtg:5.x.x

Conversation

@Lokowandtg

Copy link
Copy Markdown
Contributor

This code was developed with support from Claude AI.

This code was developed with support from Claude AI.

@Kehrlann Kehrlann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@Kehrlann Kehrlann self-requested a review July 10, 2026 07:17
.build()))
.thenMany(
requestListServiceRouteBindings(
this.cloudFoundryClient, null))

@Kehrlann Kehrlann Jul 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.cloudFoundryClient, null))
this.cloudFoundryClient, routeId))

Otherwise this test fails if it doesn't run first, because some route bindings exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants