Route policies follow ups#5242
Draft
philippthun wants to merge 1 commit into
Draft
Conversation
Move the cf:any exclusivity check into RoutePolicy#validate, drop the after_create/after_destroy callbacks in favor of a public notify_diego, and record audit events transactionally inside new RoutePolicyUpdate and RoutePolicyDestroy actions. Drop the redundant reload in the controller's update path. Add route_policy, route_policy_label_model, and route_policy_annotation_model factories and route all specs through them instead of raw model creates. Rename the leftover 'rule' terminology to 'policy' throughout the specs.
philippthun
force-pushed
the
route-policies-follow-ups
branch
from
a92962e to
0b5876f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests