Modernize legacy dependencies#172
Draft
coder13 wants to merge 3 commits into
Draft
Conversation
Replace abandoned session and analytics integrations, move the client and tooling onto supported versions, and add automated dependency and code security checks.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Load Emotion styles before the legacy JSS compatibility layer so desktop breakpoints, spacing overrides, and table flex rules win the cascade.
Preserve the MUI 4 standard TextField default and keep the first create-room label inside the dialog content boundary.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
express-socket.io-sessionbridge with direct Express session middleware shared by Socket.IOconnect-mongo6connected-react-router, and replacereact-gawith GA4-compatiblereact-ga4Why
Several core dependencies were abandoned, end-of-life, or old enough to prevent security and framework maintenance. The existing Socket.IO session bridge also pulled in a vulnerable cookie dependency, while the Universal Analytics package could not correctly use the configured GA4 property.
Impact
The client remains on React 18.3 as the compatibility bridge before React 19. Existing room, authentication, and Socket.IO behavior is preserved. MongoDB 7 is used as the safe intermediate data upgrade before an eventual MongoDB 8 move.
The migration also fixes Vite loading for the protocol/event modules and updates the lobby layout for MUI 6.
Validation
yarn install --frozen-lockfileyarn lintyarn test— 31 tests passedyarn builddocker compose config -qyarn audit— 0 vulnerabilities across 538 packagesgit diff --checkFollow-ups
defaultPropsand replace React-18-only leaf dependencies before React 19