Dev#1111
Merged
Merged
Conversation
CMG-1057: fix already-mapped locales appearing in dropdowns on restart, Add Language button stuck disabled after one addition, and rows locking prematurely before user advances past step 2. CMG-1058: route new-locale entries through localize path instead of creating duplicate entries; fix save button visibility and sticky footer in entry mapper; tighten step-1→step-3 skip guard to require all source locales mapped before bypassing step 2.
- allSourceLocalesMapped: verify each source locale exists in mapped values instead of comparing raw counts (filters out placeholder keys like UNMAPPED_LOCALE_KEY and prevents duplicates from inflating count) - LoadLanguageMapper: remove dead savedKey/savedValue/isRowSaved vars - LoadLanguageMapper: fix recentMsterLocale typo -> recentMasterLocale
…tentful, Drupal, and WordPress
…l and Drupal; improve error handling and mock implementations
feat(assets): add extractAssets function for asset mapping across Con…
- LoadLanguageMapper: skip persisting source locale when no CS locale is selected yet (prevents fallback key inflating filledMappingCount and re-enabling Add Language for an incomplete row) - entryMapper: gate Save disable on migrationStarted && !migrationCompleted so button unlocks on delta revisits after migration completes
…e-fix CMG-1057, CMG-1058 | Language Mapper and Locale Migration Fixes
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira Ticket
MIGRATION-XXXX
📋 PR Type
📝 Description
What changed?
Why?
🧩 Affected Areas
api— Node.js backendui— React frontendupload-api— Upload API serverdocker/docker-compose🧪 How to Test
Expected result:
📸 Screenshots / Recordings
🔗 Related PRs / Dependencies
✅ Author Checklist
feature/,bugfix/, orhotfix/+ 5–30 lowercase chars.env/example.envupdated if new environment variables were addednpm test)README.md/ docs updated if behaviour changed👀 Reviewer Notes