Skip to content

Fix ReevaluateExpression enabled state on session termination#2808

Merged
merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:ReEvaluate
Jul 8, 2026
Merged

Fix ReevaluateExpression enabled state on session termination#2808
merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:ReEvaluate

Conversation

@SougandhS

Copy link
Copy Markdown
Contributor

selectionChanged() now checks whether the debug target is terminated or disconnected before enabling the action, preventing stale re-evaluate actions from being invocable after the debug session has ended.

before
Screenshot 2026-07-07 at 5 24 40 PM

After
Screenshot 2026-07-07 at 5 23 48 PM

@SougandhS

Copy link
Copy Markdown
Contributor Author

Noticed while working on eclipse-jdt/eclipse.jdt.debug#976

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   58m 39s ⏱️ + 1m 11s
 4 687 tests ±0   4 665 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 955 runs  ±0  11 802 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 2d25950. ± Comparison against base commit a7c593a.

♻️ This comment has been updated with latest results.

selectionChanged() now checks whether the debug target is terminated or
disconnected before enabling the action, preventing stale re-evaluate
actions from being invocable after the debug session has ended.
@merks merks merged commit c999058 into eclipse-platform:master Jul 8, 2026
18 checks passed
@SougandhS

SougandhS commented Jul 8, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants