chore(tracing): Store incoming baggage org ID#1209
Open
szokeasaurusrex wants to merge 1 commit into
Open
Conversation
szokeasaurusrex
changed the title
org_id from baggage header
szokeasaurusrex
changed the base branch from
szokeasaurusrex/split-mod-performance
to
szokeasaurusrex/trace-propagation-context
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
3 times, most recently
from
08ed784 to
bed6146
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
from
bed6146 to
ca05426
Compare
szokeasaurusrex
changed the title
org_id from baggage header
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
from
ca05426 to
afb3de5
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/trace-propagation-context
branch
from
3f34a77 to
bedc2a2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
from
afb3de5 to
8515ce7
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/trace-propagation-context
branch
from
bedc2a2 to
b686b94
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
2 times, most recently
from
8524289 to
becf1b2
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/trace-propagation-context
branch
from
b686b94 to
9fae22a
Compare
Parse `sentry-org_id` from incoming `baggage` headers alongside `sentry-trace` and store it on `TransactionContext`. This keeps the change behavior-neutral while making the incoming org ID available for strict trace continuation work in a follow-up change. Malformed or missing org IDs are treated as absent, and baggage without a valid `sentry-trace` does not attach incoming org metadata to a fresh transaction context. Closes [#1200](#1200) Closes [RUST-252](https://linear.app/getsentry/issue/RUST-252) References [#1201](#1201) References [RUST-253](https://linear.app/getsentry/issue/RUST-253)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/org-id-baggage-parsing
branch
from
becf1b2 to
7af8474
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/trace-propagation-context
branch
from
9fae22a to
1661031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse
sentry-org_idfrom incomingbaggageheaders alongsidesentry-traceand store it onTransactionContext.This keeps the change behavior-neutral while making the incoming org ID available for strict trace continuation work in a #1201. Malformed or missing org IDs are treated as absent, and baggage without a valid
sentry-tracedoes not attach incoming org metadata to a fresh transaction context.Closes #1200
Closes RUST-252
References #1201
References RUST-253