feat!(core): Add event sampling strategy#1228
Open
szokeasaurusrex wants to merge 3 commits into
Open
Conversation
szokeasaurusrex
changed the title
Replace the public `ClientOptions::sample_rate` field with an `EventSamplingStrategy` enum while preserving the existing `sample_rate(...)` builder API for fixed-rate event sampling. This mirrors the traces sampling model and unblocks #1127 by making it possible to add a sampling function variant to `EventSamplingStrategy` without another public field replacement. BREAKING CHANGE: Remove the public `ClientOptions::sample_rate` field. Use `ClientOptions::event_sampling_strategy` to inspect event sampling configuration, and continue using `ClientOptions::sample_rate(...)` to configure a fixed sample rate. References [#1127](#1127) References [RUST-215](https://linear.app/getsentry/issue/RUST-215)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/traces-sampling-strat
branch
from
d8e15af to
b34aaa6
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sampling-strat
branch
from
ea5d131 to
8ce4708
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8ce4708. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the public
ClientOptions::sample_ratefield with anEventSamplingStrategyenum while preserving the existingsample_rate(...)builder API for fixed-rate event sampling.This mirrors the traces sampling model added in #1227 and unblocks #1127 by making it possible to add a sampling function variant to
EventSamplingStrategywithout another public field replacement.BREAKING CHANGE: Remove the public
ClientOptions::sample_ratefield. UseClientOptions::event_sampling_strategyto inspect event sampling configuration, and continue usingClientOptions::sample_rate(...)to configure a fixed sample rate.References #1127
References RUST-215