chore: Allow to change cwd of transcoder#51
Open
elthariel wants to merge 1 commit into
Open
Conversation
to help managing the two pass encoding logfiles
|
|
Contributor
Author
|
Ok, there's a CLA now. Not sure I can sign it, I need to ask my company. edit: I'm not sure I get why the CLA is required since the code is MIT ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using two pass encoders, it can be helpful to change the current working directory of the ffmpeg binaries.
This PR does just that by allowing to provide extra args to Open3 module functions.
PS: 3 tests are failing on my box, both on my branch and the up-to-date main branch, so I didn't take the time to investigate yet