Bug fixes and improvements#4
Open
rimi-itk wants to merge 7 commits into
Open
Conversation
rimi-itk
force-pushed
the
features/bug-fixes-and-clean-up
branch
from
20f352f to
b4673e5
Compare
cableman
approved these changes
Jul 2, 2022
ghbm-itk
requested changes
Jul 10, 2026
| $month = substr($cpr, 2, 2); | ||
| $year = substr($cpr, 4, 2); | ||
|
|
||
| $prefix = (int) $year < 21 ? '20' : '19'; |
There was a problem hiding this comment.
This should use the 7th digit to determine the century as per the cpr specs
There was a problem hiding this comment.
Author
rimi-itk
force-pushed
the
features/bug-fixes-and-clean-up
branch
6 times, most recently
from
1b0220f to
03a8579
Compare
rimi-itk
force-pushed
the
features/bug-fixes-and-clean-up
branch
from
03a8579 to
348f6ad
Compare
rimi-itk
force-pushed
the
features/bug-fixes-and-clean-up
branch
from
f01d80b to
8aa79a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CprValidatorclass by adding more meaningful functions names and deprecatingcheckCprfunction..extractCpr, to extract CPR numbers from a text.