Refresh CLAUDE.md and agent docs for current tooling/versions#59
Merged
Conversation
Audited the docs against the code. Corrections: - Stack: API Platform 4.1 → 4.3, image itkdev/php8.3-fpm → php8.4-fpm. - PHPStan level 6 → 8 (pr-readiness agent + the code-analysis comment, which also now notes Rector). - Drop the stale `ignore_error: true` fixtures rationale from the reload-fixtures agent (removed from the Taskfile in the mappings PR). - Note the CI-enforced index-mapping-drift gate (not just the local Stop hook) and document the test-suite layout (Contract/Consumer/Unit + tests/schemas) that has grown since CLAUDE.md was written. README is accurate (pins no versions) and left as-is.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #59 +/- ##
==========================================
Coverage 72.89% 72.89%
Complexity 232 232
==========================================
Files 29 29
Lines 653 653
==========================================
Hits 476 476
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audited README, CLAUDE.md, all
.claude/agents/*,.claude/skills/**, and.claude/settings.jsonagainstcomposer.json,phpstan.dist.neon,phpunit.dist.xml,Taskfile.yml, the workflows, and thesrc/testslayout. Fixes the stale bits.Corrected (were wrong)
itkdev/php8.3-fpm→itkdev/php8.4-fpm..claude/agents/pr-readiness.md— PHPStan level 6 → 8 (thecode-analysiscomment also now notes Rector)..claude/agents/reload-fixtures.md— dropped the staleignore_error: truefixtures rationale (removed from the Taskfile in the mappings PR).Filled gaps (testing/architecture, newly true)
index-mapping-drift.yamlvs the importer's committedresources/mappingsexport), not only the localStophook.Contract/(+ContractSchemaTest,tests/schemas/),Consumer/(aarhusguiden, os2display), the per-resource behavioural tests, andtests/Unit/.Checked and accurate (no change)
PHP floor
>=8.3, the six filters,failOnDeprecation/Notice/Warning, the PostToolUse Rector hook (#57), the skills (changelog-entry,new-resource,update-api-spec),filter-provider-reviewer, and.claude/settings.jsonhook commands. README pins no versions, so nothing stale there.