Skip to content

Fix api-spec no-change detection for oasdiff v0.1.x #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turegjorup merged 2 commits into from
Jul 9, 2026
Merged

Fix api-spec no-change detection for oasdiff v0.1.x #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ce5808
ci: fix api-spec no-change detection for oasdiff v0.1.x
turegjorup Jul 9, 2026
4e3dcfc
docs: add CHANGELOG entry for api-spec no-change detection fix
turegjorup Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/api-spec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,9 @@ jobs:
- name: Determine whether the spec changed
id: changes
run: |
if [ -s changelog.md ] && ! grep -qi 'no changes' changelog.md; then
# oasdiff writes "No changelog changes" (v0.1.x) / "No changes" (older)
# when the spec is unchanged; treat either as no change.
if [ -s changelog.md ] && ! grep -qiE 'no (changelog )?changes' changelog.md; then
echo "has_changes=true" >> "$GITHUB_OUTPUT"
else
echo "has_changes=false" >> "$GITHUB_OUTPUT"
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ See [keep a changelog] for information about writing changes to this log.

## [Unreleased]

- [PR-61](https://github.com/itk-dev/event-database-api/pull/61)
Fix the API-spec workflow's no-change detection for oasdiff v0.1.x ("No changelog changes" wording)
- [PR-60](https://github.com/itk-dev/event-database-api/pull/60)
Upgrade Elasticsearch to 8.19.18 (dev image) and the `elasticsearch/elasticsearch` client constraint to `^8.19`
- [PR-59](https://github.com/itk-dev/event-database-api/pull/59)
Expand Down