Skip to content

Update head.html #3383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielsroka wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update head.html #3383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d80ead
Update head.html
gabrielsroka Feb 23, 2023
4904ac2
Update article.md
gabrielsroka Feb 23, 2023
6b93f8e
`link` should be lowercase
gabrielsroka Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions 1-js/12-generators-iterators/2-async-iterators-generators/article.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,15 +341,12 @@ async function* fetchCommits(repo) {
headers: {'User-Agent': 'Our script'}, // github needs any user-agent header
});

const body = await response.json(); // (2) response is JSON (array of commits)
const commits = await response.json(); // (2) response is JSON (array of commits)

// (3) the URL of the next page is in the headers, extract it
let nextPage = response.headers.get('Link').match(/<(.*?)>; rel="next"/);
nextPage = nextPage?.[1];
url = response.headers.get('link').match(/<([^>]+)>; rel="next"/)?.[1];

url = nextPage;

for(let commit of body) { // (4) yield commits one by one, until the page ends
for (const commit of commits) { // (4) yield commits one by one, until the page ends
yield commit;
}
}
Expand Down
9 changes: 3 additions & 6 deletions 1-js/12-generators-iterators/2-async-iterators-generators/head.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,13 @@
headers: {'User-Agent': 'Our script'}, // github requires user-agent header
});

const body = await response.json(); // parses response as JSON (array of commits)
const commits = await response.json(); // parses response as JSON (array of commits)

// the URL of the next page is in the headers, extract it
let nextPage = response.headers.get('Link').match(/<(.*?)>; rel="next"/);
nextPage = nextPage?.[1];

url = nextPage;
url = response.headers.get('link').match(/<([^>]+)>; rel="next"/)?.[1];

// yield commits one by one, when they finish - fetch a new page url
for(let commit of body) {
for (const commit of commits) {
yield commit;
}
}
Expand Down