TPT-4280: Add integration tests for Reserved IP for IPv4#886
Open
mawilk90 wants to merge 18 commits into
Open
Conversation
mawilk90
added
testing
mawilk90
force-pushed
the
feature/TPT-4280-linode-cli-add-integration-tests-for-reserved-ip-for-ipv4
branch
from
e719cab to
cb4cd17
Compare
…ests-for-reserved-ip-for-ipv4
…ests-for-reserved-ip-for-ipv4
…ests-for-reserved-ip-for-ipv4
…ests-for-reserved-ip-for-ipv4
…ests-for-reserved-ip-for-ipv4
mawilk90
force-pushed
the
feature/TPT-4280-linode-cli-add-integration-tests-for-reserved-ip-for-ipv4
branch
from
600bc51 to
ae58218
Compare
mawilk90
requested review from
ezilber-akamai and
psnoch-akamai
and removed request for
a team
ezilber-akamai
left a comment
ezilber-akamai
left a comment
Contributor
There was a problem hiding this comment.
Tests look good and pass locally! One small issue though, left a comment about it.
Co-authored-by: Erik Zilber <ezilber@akamai.com>
|
|
||
|
|
||
| @pytest.fixture(scope="package") | ||
| def test_linode_id(linode_cloud_firewall): |
Contributor
There was a problem hiding this comment.
How about renaming this function? It starts with test, what suggest that is is test case
psnoch-akamai
approved these changes
Jul 8, 2026
psnoch-akamai
left a comment
psnoch-akamai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tests work locally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Integration tests verifying Reserved IPs CLI commands
NOTE:
PR with openapi.json for Reserved IPs is already merged, however openapi.json file is not updated yet in
linode-api-openapirepo so CLI can be build locally only using the latest openapi.json taken from the PR mentioned above✔️ How to Test
make test-int TEST_SUITE=networking TEST_ARGS="-k reserved"make test-int TEST_SUITE=tags TEST_ARGS="-k reserved"