Match the update's summary and description with its title#1073
Open
randomnoise wants to merge 1 commit into
Open
Match the update's summary and description with its title#1073randomnoise wants to merge 1 commit into
randomnoise wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple updatable packages are grouped together as an update, the group uses its
sourcein APT description as its title in GUI.The title can correspond to a package itself but not necessarily be updatable at that moment. In this case, the summary and description of the first package in the changelist are used whose name doesn't begin with
liband end withdev,dbg,common,core,dataordoc.This PR uses the source package's summary and description to match with the group's title if the source package exists. If a package doesn't exist with the title's name, the code shouldn't cause an error. (e.g., updatable package
libfprint-2-2, its sourcelibfprint: no package by that name.)This implementation doesn't feel ideal; I implemented it for minimal change in terms of lines, and I didn't want to introduce a circular dependency between
AptUpdater(oldAPTCheck) andUpdateclasses. I just wanted to explore the root cause of the issue, that's why it is kind of hacky.vim specific explanation
but updatable changes doesn't include
vim, so GUI uses first acceptable change for the summary and description:xxd.updatable packages:
vim before & after screenshots
Before:

After:
